Skip to content

Commit

Permalink
Remove the custom completion command
Browse files Browse the repository at this point in the history
Symfony 5.4 and up comes with a built-in completion command, see:

https://symfony.com/doc/5.4/console/input.html#adding-argument-option-value-completion

And any customisation to it can be done from within the rest of
commands.

So we don't need the stecman/symfony-console-completion library
neither the custom CompletionCommand any more.

This commit just removes it all completely.
  • Loading branch information
stronk7 committed Feb 10, 2023
1 parent 3e21bf3 commit f44997a
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 100 deletions.
2 changes: 0 additions & 2 deletions bin/moodle-plugin-ci
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ use MoodlePluginCI\Command\AddPluginCommand;
use MoodlePluginCI\Command\BehatCommand;
use MoodlePluginCI\Command\CodeCheckerCommand;
use MoodlePluginCI\Command\CodeFixerCommand;
use MoodlePluginCI\Command\CompletionCommand;
use MoodlePluginCI\Command\CopyPasteDetectorCommand;
use MoodlePluginCI\Command\CoverallsUploadCommand;
use MoodlePluginCI\Command\GruntCommand;
Expand Down Expand Up @@ -76,7 +75,6 @@ $application->add(new AddPluginCommand(ENV_FILE));
$application->add(new BehatCommand());
$application->add(new CodeCheckerCommand());
$application->add(new CodeFixerCommand());
$application->add(new CompletionCommand());
$application->add(new CopyPasteDetectorCommand());
$application->add(new CoverallsUploadCommand());
$application->add(new GruntCommand());
Expand Down
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
"php-parallel-lint/php-console-highlighter": "^1.0.0",
"psr/log": "^1.1.4",
"nikic/php-parser": "^4.14",
"stecman/symfony-console-completion": "^0.11.0",
"marcj/topsort": "^2.0.0",
"phpcompatibility/php-compatibility": "dev-develop#2fb82334"
},
Expand Down
51 changes: 1 addition & 50 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 0 additions & 47 deletions src/Command/CompletionCommand.php

This file was deleted.

0 comments on commit f44997a

Please sign in to comment.