Fix Psalm issues

moodlehq · Jul 3, 2020 · 849b619 · 849b619
1 parent 040ffa3
commit 849b619
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/psalm.xml b/psalm.xml
@@ -47,13 +47,29 @@
             </errorLevel>
         </PossiblyInvalidArgument>
 
-        <!-- These are due to how PhpParser classes work with properties -->
+        <!-- These are due to how Command classes work with properties -->
+        <PossiblyNullArgument>
+            <errorLevel type="suppress">
+                 <file name="src/Command/InstallCommand.php"/>
+            </errorLevel>
+        </PossiblyNullArgument>
+
+        <!-- These are due to how PhpParser and Command classes work with properties -->
         <PossiblyNullOperand>
             <errorLevel type="suppress">
-                <file name="src/Parser/StatementFilter.php"/>
+                 <file name="src/Parser/StatementFilter.php"/>
+                 <file name="src/Command/InstallCommand.php"/>
             </errorLevel>
         </PossiblyNullOperand>
 
+        <!-- These are due to how Command classes work with Application properties -->
+        <PossiblyNullReference>
+            <errorLevel type="suppress">
+                <file name="src/Command/InstallCommand.php"/>
+                <file name="src/Command/SelfUpdateCommand.php"/>
+            </errorLevel>
+        </PossiblyNullReference>
+
         <!-- Psalm is not finding inherited PHPDoc -->
         <MissingReturnType>
             <errorLevel type="suppress">

diff --git a/src/Bridge/MoodlePlugin.php b/src/Bridge/MoodlePlugin.php
@@ -42,7 +42,7 @@ class MoodlePlugin
      * EG: this is the command name and it should only
      * be used for reading configs.
      *
-     * @var string
+     * @var string|null
      */
     public $context = '';