Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the testing from Travis to GHA #139

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Sep 25, 2021

  • remove Travis integration.
  • replace it by GHA test job.
  • add some more conditions to avoid the publish job to happen.

Bye, bye, Travis!

@stronk7
Copy link
Member Author

stronk7 commented Sep 25, 2021

Once merged I'll spread it over all 7.3 and up images, as usual.

- remove Travis integration.
- replace it by GHA test job.
- add some more conditions to avoid the publish job to happen.
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good Eloy. Thanks for working on it! :-)

Bye, bye, Travis :-P

@sarjona sarjona merged commit 5a033c2 into moodlehq:master Sep 27, 2021
@stronk7 stronk7 deleted the move_tests_to_gha branch September 27, 2021 07:52
@stronk7
Copy link
Member Author

stronk7 commented Sep 27, 2021

Thanks Sara!

BTW: I was preparing the php73, php74 and php80 branches to perform the switch on them (cherry picking this issue commit from master)... and then have already pushed them without waiting for the master job to finish. So now we have:

All them running. I bet they will pass (because they passed last week for me in my cloned repo), sorry for pushing the fix too early.

Ciao :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants