Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some phpcs (phpdoc) sniffs #145

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Disable some phpcs (phpdoc) sniffs #145

merged 1 commit into from
Apr 22, 2024

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Mar 30, 2024

As far as this tool is becoming replaced by moodle-cs and has been already deprecated there isn't much interest into fixing all the missing documentation.

Hence, disabling some sniffs and applying the minimum changes towards allowing CI to pass.

Also, removing the phpcpd command (deprecated) and the phpdoc command itself (being replaced by phpcs and we don't care - in fact it was disabled for this plugin).

As far as this tool is becoming replaced
by moodle-cs and has been already deprecated
there isn't much interest into fixing all
the missing documentation.

Hence, disabling some sniffs and applying the
minimum changes towards allowing CI to pass.
@stronk7 stronk7 self-assigned this Mar 30, 2024
@stronk7 stronk7 requested a review from andrewnicols March 30, 2024 18:33
@stronk7
Copy link
Member Author

stronk7 commented Apr 22, 2024

Self-merging...

@stronk7 stronk7 merged commit ab6a27d into moodlehq:main Apr 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant