Adapt run.php to the new phpcs3 API

[sarjona]

The run.php file has been reviewed and adapted to use the new runner class.

Some changes have been done to this runner class to add some of the config settings and also to get the interactive mode working ($this->processFile($file) is the method doing the magic and the exception has been added too to exit when 'q' key is pressed).
The following code has been removed to avoid to repeat some information:
$reporter->cacheFileReport($file, $this->config);

The run.php file can be tested using the following commands:

• php run.php -h : Should display the help information
• php run.php local: Should run the codechecker over the moodle/local folder. Currently, it should return a couple of warnings in locallib.php file
• php run.php -i local: Should run the codechecker using the interactive mode (so it will stop for every file having any error/warning).

[sarjona]

The branch has been rebased to the latest 3.5.8 PHPCS3.

[vmdef]

Hi Sara!
Nice work! Thanks for work on this patch. Just some comments for your consideration, although most of them are not part of your changes, I think it worth to fix them now:

• Rebase onto current phpcs3 to include Fix comment in .travis.yml #93 and remove testing on 31 and 32 branches that fail.
• classes/runner.php
  • line 75, typo in runned -> runner
  • line 60, the property to specify an output file is reportFile.
    After another read, I realized I was wrong. I interpreted the name of the method, set_reportfile(), literally
• run.php
  • line 27, we can change dirname() to DIR
  • as we have the methods defined in \local_codechecker\runner, we could add las opciones para esconderse the warnings and specify an output file

[sarjona]

Hi Víctor!

Thanks for reviewing the patch and raising these interesting comments :-)

• I've rebased the patch to the latest.
• classes/runner.php
  • fixed typo (well spotted!)
  • I haven't changed anything in this method and I think it's OK as it is :-)
• run.php
  • As mentioned previously with your comments about includes, this part has been copied from https://github.com/moodlehq/moodle-local_codechecker/blob/phpcs3/index.php#L28-L34 so if this needs to be changed, I would suggest doing in a separate issue.
  • I think this can be done too in a separate issue. For now, the main goal of this patch was to adapt run.php to get it working with PHPCS3.

So the patch is ready again to get your eyes over it ;-)

[vmdef]

Thanks, Sara. Your proposal is sensible. Let's go as it is and we will address these questions in other issues.

[sarjona]

A separate issue has been created to see if includes in index.php and run.php can be removed: #94

[stronk7]

yay * 2!