Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rule for ignoring declare to Moodle internal check #63

Closed
wants to merge 1 commit into from

Conversation

Peterburnett
Copy link
Contributor

No description provided.

@Peterburnett
Copy link
Contributor Author

Currently Travis CI is failing due to a dependency on PHP 7.1. All other CI tests pass OK

@stronk7
Copy link
Member

stronk7 commented Jun 11, 2020

Hi @Peterburnett ,

I've picked your commit and added some unit tests to it @ master...stronk7:laptop

It's being tested @ https://travis-ci.org/github/stronk7/moodle-local_codechecker/builds/697059787 right now (against modern version of .travis that should pass on all branches)

Feel free to cherry pick the testing commit and, once green, I'll proceed to merge this. Or, alternatively, can merge it from my branch, as you prefer!

Ciao :-)

@Peterburnett
Copy link
Contributor Author

Hi Eloy,
It would be great if you could merge it from your branch, I wont have the time to pick this back up for a few days.
Thanks,
Peter

@stronk7
Copy link
Member

stronk7 commented Jun 11, 2020

Perfect, will do tomorrow (Thu) first thing. Thanks for your collaboration!

@stronk7
Copy link
Member

stronk7 commented Jun 11, 2020

This has been manually merged now, as commented above. Thanks!

@stronk7 stronk7 closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants