Upgrade PHPCompatibility to 7.1.5 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failures are due to running master on PHP5.6 |
|
@stronk7 Interested in this PR? Unsure if you saw it. No rush :) |
|
Oh @mrmark , sorry. I had this completely missed since 3.4 freeze, grrr. Looking now... and planning to do some work towards CONTRIB-6209 soon too. Thanks and excuse me! |
|
Amazing... just saw the cs_291_wip branch that I have here too.. anyway.. later...now looking to phpcompatibility... |
|
Great, thanks! |
|
Merged, thanks! About to tidy some tests and run them now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloaded and dropped in the 7.1.5 release.
Release notes: https://github.com/wimg/PHPCompatibility/releases/tag/7.1.5
In particular, this release removes NewMagicClassConstant (or at least the bad parts) which would incorrectly warn about
::classusage.