Allow CRLF files in /tests/fixtures/ directories #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have added one extra commit, unrelated to the issue being fixed here, but that updates the GHA environment to current supported Ubuntu 22.04. It shouldn't affect the outcome, let's see. |
In moodlehq#203 it was proposed to allow CRLF files in Moodle, because the original CSV specs say that those files should be CRLF. But in practice, nowadays hardly any file is CRLF and, specifically for Moodle, we have banned them in core since the night of the times. And we should continue not allowing them. Hence we are only allowing those CRLF CSV files within the /tests/fixtures/ directories, that way if anybody wants to test their CSV loaders with CRLF, they can have some fixtures at hand. Everywhere else, they will continue being forbidden. Fixes moodlehq#203
Since some time ago, GH is warning us that the Ubuntu 18.04 environment is deprecated: "The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead...." Hence, we are bumping here, to be able to cerify if everything continues working ok
stronk7
force-pushed
the
allow_crlf_in_fixtures
branch
from
4869f15 to
3c7a20b
Compare
timhunt
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #203 it was proposed to allow CRLF files in Moodle, because the original CSV specs say that those files should be CRLF.
But in practice, nowadays hardly any file is CRLF and, specifically for Moodle, we have banned them in core since the night of the times.
And we should continue not allowing them. Hence we are only allowing those CRLF CSV files within the /tests/fixtures/ directories, that way if anybody wants to test their CSV loaders with CRLF, they can have some fixtures at hand.
Everywhere else, they will continue being forbidden.
Fixes #203