Apply sensible default values for $CFG if not specified #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use the core_component functions, sensible defaults are required. These sensible defaults are available, but the check of `$CFG->dirroot` when $CFG is empty lead to a php warning, causing phpcs failures. Even if this error is fixed, the default values in $CFG are then set to NULL after including core_component, which means that uses of it work with null values and cause require errors. Fixes moodlehq#184
|
Merged, thanks! I really don't know what I was thinking with the final implementation that landed few days ago. I remember I did lot of attempts (from the original one, cloning the whole CFG to restiitute it later... to that one, only modifying the smallest possible set of variables. But obviously, the final logic was flawed when not using the standard within a moodle installation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use the core_component functions, sensible defaults are
required.
These sensible defaults are available, but the check of
$CFG->dirrootwhen $CFG is empty lead to a php warning, causing phpcs failures.
Even if this error is fixed, the default values in $CFG are then set to
NULL after including core_component, which means that uses of it work
with null values and cause require errors.
Fixes #184