Apply the ValidFunctionName to all scoped tokens #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was only being applied to classes and interfaced, now also to traits and anon classes (and anything else that can come in the future). Covered with tests.
|
I'm self-merging this, because it's trivial and correct (that's how other standards are doing their own ValidFunctionName sniffs) and now it's completely covered. And, last but not least... I need this to be able to continue working on some sniffs related with namespaces and phpdocs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was only being applied to classes and interfaces,
now also to traits and anon classes (and anything else that can
come in the future).
Covered with tests.