Allow codecoverageignore #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While playing with code coverage, there are some exceptional places that are not reachable from PHPUnit. So, it's legit to use the @codeCoverageIgnore annotations, that can be put both in phpdoc blocks and in inline comments. This commits enables the later (inline). For phpdoc block we'll have to enable them in local_moodlecheck. Covered with tests.
junpataleta
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with code coverage, there are some exceptional
places that are not reachable from PHPUnit. So, it's legit to
use the @codeCoverageIgnore annotations, that can be put
both in phpdoc blocks and in inline comments.
This commits enables the later (inline). For phpdoc block we'll
have to enable them in local_moodlecheck.
Covered with tests.
Recommended to look to the commits separately. The 1st one is implementing the feature (allow @codeCoverageIgnore annotations). And the 2nd just is applying it to codechecker own code.