Optionaly output PHPCS standard that caused the problem in UI

[kabalin]

This is tiny UI improvement to optionally (not checked by default) show the coding standard cause the issue (which will be appended to the message):

[stronk7]

98% sold, nice addition!

Only 2 points to comment:

1. Side comment: I've just seen that he custom CLI runner that we have (run.php) does not support neither the "include warnings" (always enabled) or the "show source" (always disabled). Surely at some point we should try to achieve feature-parity with the UI (although I'm not sure if anybody out there is using it, I'm not).
2. I'd suggest to add a new scenario (or maybe an example to existing ones) to the behat tests so the new feature (enabled) is tested. As far as this is an UI change, I think it deserves it.

Ciao :-)

[stronk7]

Any chance about point 2 above? Surely we can ignore 1.

[kabalin]

Any chance about point 2 above? Surely we can ignore 1.

Point 2 has been addressed, thanks for review!

Thought for a moment may be standard should always be appended in output (with no checkbox, etc.)

[stronk7]

Hi @kabalin ,

I'm sorry for being picky... but using ´admin/index.php` as laboratory for the test doesn't sound like the better idea (they can be fixed... whatever).

Would you mind using any of the files under <codechecker>/moodle/tests/fixtures instead? I imagine they are way more stable than any file in core.

I'd point you to local/codechecker/moodle/tests/fixtures/files/moodleinternal/problem.php, for example, that is modern and I don't think we'll change it ever. Note that it will work for behat runs (not for normal use, because fixtures are excluded normally). If you want to see the problems in that file normally, you always can hack index.php and add define('BEHAT_SITE_RUNNING', 1); to see exactly what behat will see.

Sorry!

[kabalin]

You are right @stronk7, I was following a quck way ))

[kabalin]

Should be ready for another review @stronk7 , sorry.

[stronk7]

Looks perfect, thanks, @kabalin !