Allow phpcs annotations + report wrong testcase classes in class lines instead of line 0 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
force-pushed
the
allow_phpcs_annotations
branch
from
09ee487 to
8d5cc8c
Compare
This implies modifying the BoilerplateComment sniff to detect them and, conditionally, do things slightly differently. Also, part of WIP, the existing tests have been moved to own testcase and completeted to 100% cover the Sniff. This fixes moodlehq#171.
Instead of reporting the moodle.PHPUnit.TestCaseNames.Missing error in line 0, when classes have been found incorrect, issue an error on the lines they are declared. If no classes are found, then the reporting line will continue being 0. Covered with tests.
stronk7
force-pushed
the
allow_phpcs_annotations
branch
from
8d5cc8c to
58d8c25
Compare
andrewnicols
approved these changes
Jan 10, 2022
|
These changes look good to me. Merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow phpcs:xxxx comments / annotations in first line of the files
This implies modifying the BoilerplateComment sniff to detect them
and, conditionally, do things slightly differently.
Also, part of WIP, the existing tests have been moved to own testcase
and completeted to 100% cover the Sniff.
Report missing testcase classes in the line the classes are
Instead of reporting the moodle.PHPUnit.TestCaseNames.Missing error
in line 0, when classes have been found incorrect, issue an error
on the lines they are declared.
If no classes are found, then the reporting line will continue being 0.
This fixes #171.