Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify alternative for error_log forbidden function. #146

Merged
merged 1 commit into from
May 27, 2021

Conversation

kabalin
Copy link
Member

@kabalin kabalin commented May 20, 2021

The question about what function should be used instead of forbidden error_log is mentioned in discussion from time to time. This patch is specifying the most approriate replacement.

Related discussion in MDL-58374.

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure debugging() is the solution always (maybe it all should be explained somewhere)... but in the other side, I agree it can be an acceptable initial suggestion.

@kabalin kabalin force-pushed the error-log-alternative branch from 3a39ee8 to 9234c64 Compare May 26, 2021 09:09
Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍅 !

@stronk7 stronk7 merged commit 0019069 into moodlehq:master May 27, 2021
@stronk7
Copy link
Member

stronk7 commented May 27, 2021

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants