Forbidden and deprecated functions #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing important, just switching from constructor to properties and adding some explanations about why we have that Sniff extending the Generic one instead of reusing it.
To be able to add our own deprecations and messages we have extended the existing Generic DeprecatedFunctions Sniff. This version shows the alternatives and is able to process together both the internal (PHP) deprecated functions and our own ones (print_error). Covered with tests. This fixes moodlehq#137
sarjona
approved these changes
Apr 14, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes with 2 commits, first one slightly modifying/modernizing our
ForbiddenFunctionsSniff, adding also some comments bout why we are using it.And then a second commit where our new
DeprecatedFunctionsis introduced, really similar to theForbiddenFunctionsone, able to detect both PHP own deprecated functions and our ones, with alternatives where available.Note that we have had to implement the
DeprecatedFunctions->addError()method because theGeneric.DeprecatedFunctionsone is missing support to show the alternatives. I've created squizlabs/PHP_CodeSniffer#3295 about that. If accepted upstream, we'll be able to remove that implementation from our Sniff.Covered with tests (that hopefully will be all green soon) and implements #137.
Ciao :-)