Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass excluded directories/files as CLI option #136

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

adpe
Copy link
Contributor

@adpe adpe commented Feb 22, 2021

Hi @stronk7

Over the GUI it was implemented (https://tracker.moodle.org/browse/CONTRIB-3582), but no for CLI usage.

I've just made basics test usage due this small changes. But it works for my use case.

HTH
Adrian

@stronk7
Copy link
Member

stronk7 commented Feb 23, 2021

Thanks @adpe !

In order to make this 100% perfect I'd suggest to:

  1. Add also a "short" option alternative, say 'e' => 'exclude', for example.
  2. Amend the 'clihelp' lang string to explain the new e/exclude option. Maybe in a similar wording than the shown in the UI (that is in the 'info' lang string), telling about comma separated and asterisks as wildchars..

Ciao :-)

@adpe adpe force-pushed the feature/exclude-on-cli branch from e92eaa4 to a9da190 Compare February 23, 2021 15:18
@adpe
Copy link
Contributor Author

adpe commented Feb 23, 2021

Good catches @stronk7

And I'm with you, it should be consistent. I hope you're now happy.

Thanks for merging it and hear you soon
Adrian

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, thanks @adpe !

@stronk7 stronk7 merged commit 4505b2b into moodlehq:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants