MDLSITE-5739 mustache_lint: error when running on openjdk11

[kabalin]

More details:

• https://tracker.moodle.org/browse/MDLSITE-5739
• Mustache liniting: "WARNING: Problem calling HTML validator" open-lms-open-source/moodle-plugin-ci#91

As I can see, repo does not include package-lock.json, I guess this is intentional, as previously requirement was "^17.3.0" (any compatible version)? I do not use "^18.11.5" as it seems bring up unstable releases above that version when npm is initialised or updated. Perhaps we need to introduce package-lock.json to make sure that end user is using the same version which has been integration-tested here?

[kabalin]

I think travis fails on https://github.com/moodlehq/moodle-local_ci/blob/master/mustache_lint/mustache_lint.sh#L30 (e.g. "11.0.2" > "1.8" 😉 ), will see tomorrow if it is possbile to do proper semver comparison.

[stronk7]

Thanks Ruslan, nice stuff. And great to have it covered and working against more envs! Let's see the remaining little details...

[kabalin]

Thinking more. May be we should group all mustache tests and run them in all available java environments, and not differentiate between trusty and xenial?

[stronk7]

Thanks @kabalin !

Just a couple of questions:

1. With xenial becoming the default one... maybe we'll need to also add explicitly the trusty runs to the matrix/include? If I understand it properly we may end running xenial twice unless we explicitly set the dist for each run, isn't it?

2. About testing on all available java environments I really don't know if it's worth it* . Surely I'd wait somebody to report that it's not working properly with java xxxxx instead of continuously try to keep the tests on top of a bunch of flavors and versions.

* note that, personally, i'm not sure, either, if it's worth testing it over multiple ubuntu distributions, it just doubles the running time when, by default, I'd expect things to continue working the same. But I don't oppose, just 1) above called my attention.

Other than that 1), I'm happy with this one as is, tell me that do you think so we can advance it...

Ciao :-)

[stronk7]

Any thought about that 1) above, @kabalin ? I had this completely forgotten, sorry, just arrived here today by coincidence (another PR).

[kabalin]

Hi @stronk7, sorry I missed the your first comment completely (I was on holidays most of June).

1. you are right :)
2. I actually was thinking thought the same before reading "*" part. We know it works fine with openjdk8, so testing explicitly if it "still works" with old version probably not required. The default recommendation for anyone who has issues in older distro would be just to switch to xenial, which we tested against in this CI scenario. To the best of my knowledge, moodle-plugin-ci that is using this package as dependency has no critical issues using xenial either, apart of mustache linting, which this fix is addressing.

Changes will follow in a moment.

UPD: for some reason commit I added is shown above this comment.

[stronk7]

Here we go, thanks!

[kabalin]

👍