Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default PHP version to 8.1 for behat GHA #278

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented Nov 27, 2023

In #277 I'm getting some failures with a couple of behat failures jobs and looking at them I think last week, when #276 was integrated, there were a couple of missing places where the PHP version needed to be updated to.

Copy link
Member

@paulholden paulholden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! LGTM

@stronk7
Copy link
Member

stronk7 commented Nov 27, 2023

Whoops! LGTM2

@sarjona sarjona merged commit 40142ea into moodlehq:master Nov 27, 2023
113 checks passed
@sarjona
Copy link
Member Author

sarjona commented Nov 27, 2023

Thanks Paul and Eloy! :-*

@sarjona sarjona deleted the php81fix branch November 27, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants