Allow missing commas when last element is same line than closer (take #2) #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
============================================
- Coverage 96.46% 96.17% -0.30%
- Complexity 517 543 +26
============================================
Files 22 23 +1
Lines 1471 1542 +71
============================================
+ Hits 1419 1483 +64
- Misses 52 59 +7 ☔ View full report in Codecov by Sentry. |
stronk7
force-pushed
the
fix_coma_closer_same_line
branch
from
bda916a to
5ff59e5
Compare
|
Note: I've added a candidate commit here that proceeds to:
I've commented with the same @ #76. (note that it's causing the code-coverage check to fail but we shouldn't mind too much. That is tested upstream in PHPCSExtra and here we are just testing the outcome for our very-own allowed multi-line arrays). Ciao :-) |
Comes with some tests to ensure that the case is now covered and we are allowing to miss those commas in the last array element when the array closer is in same line. Fixes moodlehq#76
We need this applied ASAP, because it's causing troubles with many arrays that are allowed, so we cannot wait for PHPCSExtra v1.2.0 to be released. So, with this commit, we are moving to own (copied verbatim) Sniff. And adjusting tests and other small bits. Note that this commit will be 100% reverted once PHPCSExtra is released and then we'll be back to the upstream Sniff. See moodlehq#82
stronk7
force-pushed
the
fix_coma_closer_same_line
branch
from
5ff59e5 to
1c295bb
Compare
|
Self-merged. As commented above, the code-coverage report, missing 7 lines is ignorable, that Sniff is fully tested upstream and here we are only testing that the outcome matches Moodle coding style cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clone of #80 that was closed by mistake...
Comes with some tests to ensure that the case is now covered and we are allowing to miss those commas in the last array element when the array closer is in same line.
Fixes #76
Holding this as draft PR until PHPCSExtra 1.2.0 is released. Then we'll have to change
composer.jsonto point to that new release and this PR will be ready.