Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test files must be named _test.php #67

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

andrewnicols
Copy link
Contributor

No description provided.

@andrewnicols andrewnicols force-pushed the testsMustHaveNamePattern branch from 292a7b6 to 9d80834 Compare September 22, 2023 15:49
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #67 (9d80834) into main (c48e0a4) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #67   +/-   ##
=========================================
  Coverage     96.26%   96.26%           
- Complexity      494      495    +1     
=========================================
  Files            21       21           
  Lines          1391     1393    +2     
=========================================
+ Hits           1339     1341    +2     
  Misses           52       52           
Files Changed Coverage Δ
moodle/Util/MoodleUtil.php 97.27% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stronk7
Copy link
Member

stronk7 commented Sep 22, 2023

Thanks @andrewnicols , I can confirm that the changes fix the problem with coverage.php being reported as missing any valid testcase class.

@stronk7 stronk7 merged commit 0a4fc09 into moodlehq:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants