MDLSITE-6594 revert #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Thanks @junpataleta ,
changes look ok, testing passes, so that all we need.
Going to merge now. Next steps:
- Comment @ MDLSITE-6594.
- Make a moodle-cs release.
- Apply the changes to our CIs (CiBoT).
- Make a moodle-local_codechecker release.
- Make a moodle-plugin-ci release.
Ciao :-)
stronk7
added a commit
to stronk7/moodle-plugin-ci
that referenced
this pull request
Mar 14, 2023
And revert some changes that were done for previous release, about spacing before assignment, they aren't needed any more. See: moodlehq/moodle-cs#44
stronk7
added a commit
to stronk7/moodle-plugin-ci
that referenced
this pull request
Mar 14, 2023
And revert some changes that were done for previous release, about spacing before assignment, they aren't needed any more. See: moodlehq/moodle-cs#44
stronk7
added a commit
to stronk7/moodle-plugin-ci
that referenced
this pull request
Mar 14, 2023
And revert some changes that were done for previous release, about spacing before assignment, they aren't needed any more. See: moodlehq/moodle-cs#44
stronk7
added a commit
to stronk7/moodle-plugin-ci
that referenced
this pull request
Mar 14, 2023
And revert some changes that were done for previous release, about spacing before assignment, they aren't needed any more. See: moodlehq/moodle-cs#44 Also the js / map files because the NodeJS bump in core has been now reverted. See: https://tracker.moodle.org/browse/MDL-77559
|
(done, all the releases and updates have been applied) |
stronk7
added a commit
to stronk7/moodle-plugin-ci
that referenced
this pull request
Mar 14, 2023
And revert some changes that were done for previous release, about spacing before assignment, they aren't needed any more. See: moodlehq/moodle-cs#44 Also the js / map files because the NodeJS bump in core has been now reverted. See: https://tracker.moodle.org/browse/MDL-77559
Closed
mchurchward
pushed a commit
to brickfield/moodle-plugin-ci
that referenced
this pull request
Mar 21, 2023
And revert some changes that were done for previous release, about spacing before assignment, they aren't needed any more. See: moodlehq/moodle-cs#44 Also the js / map files because the NodeJS bump in core has been now reverted. See: https://tracker.moodle.org/browse/MDL-77559
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy agreed upon in MDLSITE-6594, where there should only be one space before the assignment operators, is causing CI failures on existing code with multiple spaces before the assignment operator. Let's revert this for now while we revisit this policy.