Ignore invalid method names using the Override attribute #170
+173
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
============================================
+ Coverage 98.09% 98.11% +0.02%
- Complexity 935 947 +12
============================================
Files 40 40
Lines 2777 2807 +30
============================================
+ Hits 2724 2754 +30
Misses 53 53 ☔ View full report in Codecov by Sentry. |
andrewnicols
force-pushed
the
ignoreFunctionCasingIfOverridden
branch
from
5454276 to
2e55968
Compare
stronk7
requested changes
Jun 19, 2024
andrewnicols
force-pushed
the
ignoreFunctionCasingIfOverridden
branch
from
2e55968 to
48f8099
Compare
|
Huzzah. Good catches on those. I wrote this about 10 minutes before you did the last release and screwed up the rebase. |
stronk7
approved these changes
Jun 19, 2024
|
Here we go! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful where we must override methods in third-party libraries.