Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extra consecutive header lines after the official boilerplate #169

Merged

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Jun 17, 2024

Once the official boilerplate checks have been performed, allow the "block" to be expanded with any extra information.

As far as the block is a number of consecutive comment lines, exclusively separated by \n, that's allowed.

Note that any spacing different from \n or any non consecutive comment line will stop the sequence.

Fixes: #168

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (91661a1) to head (dd772ea).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #169   +/-   ##
=========================================
  Coverage     98.08%   98.09%           
- Complexity      932      935    +3     
=========================================
  Files            40       40           
  Lines          2769     2777    +8     
=========================================
+ Hits           2716     2724    +8     
  Misses           53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7 stronk7 force-pushed the allow_extra_consecutive_information_in_header branch 3 times, most recently from 255f8cb to c32e6bb Compare June 17, 2024 10:36
Once the official boilerplate checks have been performed, allow
the "block" to be expanded with any extra information.

As far as the block is a number of consecutive comment lines,
exclusively separated by \n, that's allowed.

Note that any spacing different from \n or any non consecutive
comment line will stop the sequence.
@stronk7 stronk7 force-pushed the allow_extra_consecutive_information_in_header branch from c32e6bb to dd772ea Compare June 17, 2024 10:37
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stronk7!
Thanks for working on this. The patch looks good and it's great you also covered it with unit tests. Well done! :-)

@sarjona sarjona merged commit 4feec2a into moodlehq:main Jun 19, 2024
13 checks passed
@stronk7
Copy link
Member Author

stronk7 commented Jun 19, 2024

Tata, @sarjona !

@stronk7 stronk7 deleted the allow_extra_consecutive_information_in_header branch June 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected empty line after the boilerplate check breaks all workplace code
2 participants