Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn about missing docblocks when a method has the #[\Override] attribute #160

Merged
merged 1 commit into from
May 29, 2024

Conversation

andrewnicols
Copy link
Contributor

Fixes #155

POC

@andrewnicols
Copy link
Contributor Author

Need to add some unit tests for attributes helper.

I'm not going to make this handle fully-qualified checks right now. We'll see if phpcsextra or phpcs do so.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (c9b7667) to head (fa1c22b).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #160      +/-   ##
============================================
+ Coverage     97.90%   97.93%   +0.03%     
- Complexity      850      860      +10     
============================================
  Files            37       38       +1     
  Lines          2524     2564      +40     
============================================
+ Hits           2471     2511      +40     
  Misses           53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewnicols andrewnicols force-pushed the methodOverrides branch 2 times, most recently from 14efeaf to 50f13d0 Compare April 24, 2024 02:52
@andrewnicols andrewnicols marked this pull request as ready for review May 28, 2024 02:32
@andrewnicols
Copy link
Contributor Author

I've been running this locally for the past month and haven't encountered any weird bugs or issues. Pushing for review.

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've left a comment @ #155 about we needing to add this to the devdocs and, maybe, explain better when inherited docs should be added or avoided.

https://moodledev.io/general/development/policies/codingstyle#functions

Ciao :-)

@stronk7
Copy link
Member

stronk7 commented May 29, 2024

(whops, if you could rebase this on top of current main, that would be great, I'll do in a couple of hours if you cannot)

@andrewnicols andrewnicols changed the title WIP: Missing docblocks for #[\Override] Do not warn about missing docblocks when a method has the #[\Override] attribute May 29, 2024
@stronk7 stronk7 merged commit 4431d70 into moodlehq:main May 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Train moodle.Commenting.MissingDocblock.Missing to understand #[\Override]
2 participants