Add new sniff to detect and remove constructor @return docs #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
added a commit
to andrewnicols/moodle-cs
that referenced
this pull request
Apr 17, 2024
andrewnicols
force-pushed
the
constructorShouldNotReturn
branch
from
d0a5198 to
a917e01
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
============================================
- Coverage 97.99% 97.96% -0.04%
+ Complexity 886 873 -13
============================================
Files 39 39
Lines 2647 2603 -44
============================================
- Hits 2594 2550 -44
Misses 53 53 ☔ View full report in Codecov by Sentry. |
andrewnicols
added a commit
to andrewnicols/moodle-cs
that referenced
this pull request
Apr 17, 2024
andrewnicols
force-pushed
the
constructorShouldNotReturn
branch
from
a917e01 to
a0d7eb1
Compare
andrewnicols
added a commit
to andrewnicols/moodle-cs
that referenced
this pull request
Apr 17, 2024
andrewnicols
force-pushed
the
constructorShouldNotReturn
branch
from
a0d7eb1 to
74195d7
Compare
|
Inspired by your docblock fixes. |
|
LGTM. The removal looks a little bit complex, more yet, I must confess that I was sure that the fixer had some utility function to remove lines, but I was wrong and it only has functions to add new ones ( |
|
pong! |
andrewnicols
added a commit
to andrewnicols/moodle-cs
that referenced
this pull request
May 28, 2024
andrewnicols
force-pushed
the
constructorShouldNotReturn
branch
from
74195d7 to
7cd3704
Compare
|
I agree - there should really be a removeLine!! Drives me mad that there isn't. @marinaglancy are you able to review this? |
andrewnicols
added a commit
to andrewnicols/moodle-cs
that referenced
this pull request
May 28, 2024
andrewnicols
force-pushed
the
constructorShouldNotReturn
branch
from
7cd3704 to
0e513c4
Compare
stronk7
pushed a commit
to andrewnicols/moodle-cs
that referenced
this pull request
May 31, 2024
stronk7
force-pushed
the
constructorShouldNotReturn
branch
from
833478c to
b25ab9a
Compare
|
I've amended the commit to resolve the changelog conflicts. |
stronk7
pushed a commit
to andrewnicols/moodle-cs
that referenced
this pull request
May 31, 2024
stronk7
force-pushed
the
constructorShouldNotReturn
branch
from
b25ab9a to
9573f90
Compare
stronk7
force-pushed
the
constructorShouldNotReturn
branch
from
9573f90 to
228d21b
Compare
stronk7
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.