Revert "Downgrade code to be PHP 7.0 compliant." #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=========================================
Coverage 96.73% 96.73%
Complexity 586 586
=========================================
Files 26 26
Lines 1625 1625
=========================================
Hits 1572 1572
Misses 53 53 ☔ View full report in Codecov by Sentry. |
This reverts commit edb2b85. This partially reverts some code that was done long ago to keep compatibility with PHP 7.0. As far as moodle-cs now only supports PHP 7.4 and up, we can move back to use return types. Fixes moodlehq#107
stronk7
force-pushed
the
revert_old_7_0_support_commit
branch
from
0d48d28 to
68ca06c
Compare
andrewnicols
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit edb2b85.
This partially reverts some code that was done long ago to keep compatibility with PHP 7.0.
As far as moodle-cs now only supports PHP 7.4 and up, we can move back to use return types.
Fixes #107