Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MissingDocblock names more specific #154

Closed
andrewnicols opened this issue Apr 16, 2024 · 0 comments · Fixed by #156
Closed

Make MissingDocblock names more specific #154

andrewnicols opened this issue Apr 16, 2024 · 0 comments · Fixed by #156

Comments

@andrewnicols
Copy link
Contributor

At the moment the warnings/errors all use the identifier Missing. These should include the type that is missing, for example:

  • moodle.Commenting.MissingDocblock.File
  • moodle.Commenting.MissingDocblock.Class
  • moodle.Commenting.MissingDocblock.Method
  • moodle.Commenting.MissingDocblock.Function
  • moodle.Commenting.MissingDocblock.Constant
  • moodle.Commenting.MissingDocblock.Property
andrewnicols added a commit to andrewnicols/moodle-cs that referenced this issue Apr 17, 2024
@andrewnicols
Make MissingDoclock code more specific (Fixes moodlehq#154)
6a4a170
andrewnicols added a commit to andrewnicols/moodle-cs that referenced this issue Apr 17, 2024
@andrewnicols
Make MissingDoclock code more specific (Fixes moodlehq#154)
cb0d73b
@stronk7 stronk7 linked a pull request Jun 14, 2024 that will close this issue
Make MissingDoclock code more specific (Fixes #154) #156
Merged
stronk7 added a commit that referenced this issue Jun 14, 2024
@stronk7
Merge pull request #156 from andrewnicols/missingDocblockMoreSpecific
22b99c9 
Make MissingDoclock code more specific (Fixes #154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make MissingDoclock code more specific (Fixes #154) andrewnicols/moodle-cs
1 participant
@andrewnicols