New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix array returned by recording playback #31

Merged

andrewnicols merged 1 commit into moodlehq:main from call-learning:fix-recording-playback-v2

Feb 23, 2023

Collaborator

laurentdavid commented Feb 22, 2023

This fix make sure that playback are working both with and without MDL-74664 patch


          Fix array returned by recording playback

76760e1

* This fix make sure that playback are working both with and without MDL-74664
patch

andrewnicols approved these changes

View reviewed changes

Contributor

andrewnicols commented Feb 23, 2023

In future I think we need to look into testing these changes better.

We need unit tests on this mock, and we need to have a functional test against Moodle with both phpunit and bigbluebutton for those testsuites.

andrewnicols merged commit 01d6c3b into moodlehq:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet