Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] migrate Behat page #270

Merged
merged 4 commits into from
Jul 8, 2022
Merged

[docs] migrate Behat page #270

merged 4 commits into from
Jul 8, 2022

Conversation

ilyatregubov
Copy link
Contributor

@ilyatregubov ilyatregubov commented Jun 30, 2022

There is Information to re-home section that needs to be moved once we migrate subpage for writing Behat tests

@netlify
Copy link

netlify bot commented Jun 30, 2022

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e723a65
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/62c7c49d8b398700083b2e64
😎 Deploy Preview https://deploy-preview-270--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 71 🟢 98 🟢 100 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 70 🟢 96 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 85 🟢 96 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 86 🟢 96 🟢 100 🟢 100 🟢 100 Report

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ilyatregubov!
Thanks for migrating this page :-) As you'll see, I've raised a few comments, so feel free to review/fix them whenever you can :-)

general/development/tools/behat.md Outdated Show resolved Hide resolved
general/development/tools/behat.md Outdated Show resolved Hide resolved
general/development/tools/behat.md Outdated Show resolved Hide resolved
general/development/tools/behat.md Outdated Show resolved Hide resolved
general/development/tools/behat.md Outdated Show resolved Hide resolved
general/development/tools/behat.md Outdated Show resolved Hide resolved
general/development/tools/behat.md Outdated Show resolved Hide resolved
general/development/tools/behat.md Outdated Show resolved Hide resolved
general/development/tools/behat.md Outdated Show resolved Hide resolved
general/development/tools/behat.md Outdated Show resolved Hide resolved
@ilyatregubov ilyatregubov force-pushed the behatpage branch 2 times, most recently from d78baa2 to d1daaa1 Compare July 5, 2022 13:21
@ilyatregubov
Copy link
Contributor Author

Hi @sarjona !!

Thanks for review. I addressed you comments. I think the request is ready for another round

@sarjona sarjona linked an issue Jul 6, 2022 that may be closed by this pull request
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ilya!
Thanks a lot for reviewing and improving the Behat docs! As you'll see, only minor changes are required ;-) We're almost there!!

general/development/tools/behat/index.md Outdated Show resolved Hide resolved
general/development/tools/behat/index.md Outdated Show resolved Hide resolved
general/development/tools/behat/index.md Outdated Show resolved Hide resolved
general/development/tools/behat/index.md Outdated Show resolved Hide resolved
general/development/tools/behat/index.md Outdated Show resolved Hide resolved
general/development/tools/behat/writing.md Show resolved Hide resolved
general/development/tools/behat/writing.md Outdated Show resolved Hide resolved
general/development/tools/behat/browsers.md Outdated Show resolved Hide resolved
general/development/tools/behat/browsers.md Outdated Show resolved Hide resolved
general/development/tools/behat/browsers.md Outdated Show resolved Hide resolved
@ilyatregubov
Copy link
Contributor Author

Thanks @sarjona !
Fixed. Also added one more page for supported browsers

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ilyatregubov!
Thanks for improving the patch and adding one more page! It looks great! As you'll see, only one minor change and we'll be able to merge it! ;-)

@ilyatregubov
Copy link
Contributor Author

Thanks @sarjona !

Done!

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ilya! :-)

@sarjona sarjona merged commit e9300cb into moodle:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https://docs.moodle.org/dev/Running_acceptance_test
2 participants