-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] migrate Behat page #270
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ilyatregubov!
Thanks for migrating this page :-) As you'll see, I've raised a few comments, so feel free to review/fix them whenever you can :-)
d78baa2
to
d1daaa1
Compare
Hi @sarjona !! Thanks for review. I addressed you comments. I think the request is ready for another round |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Ilya!
Thanks a lot for reviewing and improving the Behat docs! As you'll see, only minor changes are required ;-) We're almost there!!
Thanks @sarjona ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ilyatregubov!
Thanks for improving the patch and adding one more page! It looks great! As you'll see, only one minor change and we'll be able to merge it! ;-)
Thanks @sarjona ! Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ilya! :-)
There is Information to re-home section that needs to be moved once we migrate subpage for writing Behat tests