Improvement: Add restriction for site admins to smartmenu(item), resolves #421 .

[NJahreis]

Hi everyone,

like @VlastimilValaVspj (#421) suggested I would like to have a smartmenu only visible to site admins where I can directly link to some often used settings.
The current pull request code works but changes to the behat tests are not yet implementeted, as I would like to check if any major changes are necessary first before looking into the tests.

[NJahreis]

I'll fix the typo in boost_union/tests/behat/theme_boost_union_smartmenusettings_menus_rules.feature in the next commit during review to save on running the complete CI run again.

[abias]

Hi @NJahreis ,

many thanks for working on this nice improvement and welcome to the club of Boost Union contributors.

Your code looked generally spot-on and, during my initial review, I had just rebased the branch onto latest main and had made some minor adjustments to the comments.

But then I thought about the case that a menu (item) should be shown to all user except site admins which is not covered by your improvement yet and which also can only be realized with the other existing restrictions with additional effort.
That's why I went ahead and changed your checkbox to a 3-value select box. I hope you find this as useful as I do.

I will merge the PR as soon as the tests are green again.

Cheers,
Alex