starred courses popover in navbar throws js error on every page. #759
Assignees
Labels
bug
Something which isn't working
Comments
davidscotson
added
the
new
abias
added
bug
abias
added a commit
that referenced
this issue
Nov 19, 2024
…if Boost Union or Boost Union child is active, resolves #759.
abias
added a commit
that referenced
this issue
Nov 19, 2024
…if Boost Union or Boost Union child is active, resolves #759.
abias
moved this from Ready for REVIEW
to In Progress REVIEW
in Boost Union Planning Board
|
Hi @davidscotson , many thanks for raising this issue. I can reproduce the JavaScript console error on Moodle 4.5 but also on older versions down to 4.1. I will investitate and hopefully fix it shortly. Regarding your additional comment that the starred courses feature is shown for other active themes as well, you are completely right. We have missed that detail in the initial implementation. Cheers, |
|
I think I found the reason for the JS console error as well: This is removed now in the updated PR. |
abias
added a commit
that referenced
this issue
Nov 19, 2024
…if Boost Union or Boost Union child is active, resolves #759.
github-project-automation
bot
moved this from In Progress REVIEW
to Ready for BACKPORT
in Boost Union Planning Board
abias
added a commit
that referenced
this issue
Nov 20, 2024
…if Boost Union or Boost Union child is active, resolves #759. (#762) * Bugfix: The starred courses popover in the navbar must only be shown if Boost Union or Boost Union child is active, resolves #759. * Bugfix: The starred courses popover showed a JavaScript error in the browser JS console, resolves #759
abias
added a commit
that referenced
this issue
Nov 20, 2024
…if Boost Union or Boost Union child is active, resolves #759. (#762) * Bugfix: The starred courses popover in the navbar must only be shown if Boost Union or Boost Union child is active, resolves #759. * Bugfix: The starred courses popover showed a JavaScript error in the browser JS console, resolves #759
abias
added a commit
that referenced
this issue
Nov 20, 2024
…if Boost Union or Boost Union child is active, resolves #759. (#762) * Bugfix: The starred courses popover in the navbar must only be shown if Boost Union or Boost Union child is active, resolves #759. * Bugfix: The starred courses popover showed a JavaScript error in the browser JS console, resolves #759
abias
added a commit
that referenced
this issue
Nov 20, 2024
…if Boost Union or Boost Union child is active, resolves #759. (#762) * Bugfix: The starred courses popover in the navbar must only be shown if Boost Union or Boost Union child is active, resolves #759. * Bugfix: The starred courses popover showed a JavaScript error in the browser JS console, resolves #759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On our 4.5 test site, enabling the "Show starred courses popover in the navbar" option in the settings causes a JS console error on every page.
To Reproduce
Steps to reproduce the behavior:
/admin/settings.php?section=theme_boost_union_feelUncaught TypeError: controller.registerEventListeners is not a functionAdditional context
When investigating this I switched between themes using the
?theme=functionality. The error persisted across other themes, and the star continued to be displayed in the navbar on Classic and vanilla Boost themes. After selecting a different theme in the settings to switch the theme entirely, the star in the navbar was still visible and active if enabled in Boost Union. I'm assuming that's not intended either.The text was updated successfully, but these errors were encountered: