Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'Implicitly marking a parameter as nullable is deprecated since PHP 8.4' codechecker warning #667

Closed
abias opened this issue Jun 5, 2024 · 0 comments
Closed

Fix 'Implicitly marking a parameter as nullable is deprecated since PHP 8.4' codechecker warning #667

abias opened this issue Jun 5, 2024 · 0 comments
Assignees
@abias
Labels
cleanup Something which has to be cleaned up or improved in the inner workings of the plugin

Comments

@abias
Copy link
Member

abias commented Jun 5, 2024

Some days ago, Github actions started to throw these codechecker warnings:

FILE: /home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/classes/smartmenu_item.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------
 1321 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable
      |         | instead. Found implicitly nullable parameter: $type.
      |         | (PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated)
 1338 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be explicitly nullable
      |         | instead. Found implicitly nullable parameter: $option.
      |         | (PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------------------
@abias abias added the cleanup Something which has to be cleaned up or improved in the inner workings of the plugin label Jun 5, 2024
@abias abias self-assigned this Jun 5, 2024
@abias abias moved this to Ready for DEV in Boost Union Planning Board Jun 5, 2024
abias added a commit that referenced this issue Jun 5, 2024
@abias
Cleanup: Fix 'Implicitly marking a parameter as nullable is deprecate…
2bea998 
…d since PHP 8.4' codechecker warning, resolves #667.
@abias abias moved this from Ready for DEV to Ready for REVIEW in Boost Union Planning Board Jun 5, 2024
@abias abias moved this from Ready for REVIEW to In Progress REVIEW in Boost Union Planning Board Jun 5, 2024
@abias abias closed this as completed in f42e9c3 Jun 6, 2024
@github-project-automation github-project-automation bot moved this from In Progress REVIEW to Ready for Backport in Boost Union Planning Board Jun 6, 2024
abias added a commit that referenced this issue Jun 9, 2024
@abias
Cleanup: Fix 'Implicitly marking a parameter as nullable is deprecate…
83c1a0b 
…d since PHP 8.4' codechecker warning, resolves #667. (#668)
abias added a commit that referenced this issue Jun 9, 2024
@abias
Cleanup: Fix 'Implicitly marking a parameter as nullable is deprecate…
5dcfad8 
…d since PHP 8.4' codechecker warning, resolves #667. (#668)
abias added a commit that referenced this issue Jun 9, 2024
@abias
Cleanup: Fix 'Implicitly marking a parameter as nullable is deprecate…
34ca96f 
…d since PHP 8.4' codechecker warning, resolves #667. (#668)
@abias abias moved this from Ready for Backport to Ready for Release Test in Boost Union Planning Board Jun 9, 2024
@abias abias moved this from Ready for Release Test to Ready for Release in Boost Union Planning Board Jun 10, 2024
@abias abias moved this from Ready for Release to CLOSED in Boost Union Planning Board Jun 12, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@abias
Cleanup: Fix 'Implicitly marking a parameter as nullable is deprecate…
fcff95f 
…d since PHP 8.4' codechecker warning, resolves moodle-an-hochschulen#667. (moodle-an-hochschulen#668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abias abias

Labels
cleanup Something which has to be cleaned up or improved in the inner workings of the plugin
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abias