Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Make the footer "Documentation for this page" link more configurable #649

Closed
lucaboesch opened this issue May 5, 2024 · 0 comments · Fixed by #650
Closed

Improvement: Make the footer "Documentation for this page" link more configurable #649

lucaboesch opened this issue May 5, 2024 · 0 comments · Fixed by #650
Assignees
@lucaboesch
Labels
improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)

Comments

@lucaboesch
Copy link
Collaborator

lucaboesch commented May 5, 2024 •
edited
Loading

For my page, I need the "Documentation for this page" link to miss the fa-book icon and to open on a new tab.
The default behaviour is with icon and opening in the same page, which would puzzle the users, because on our site it has always been this way.
Note: There is the "Open in new window setting", in Site Administration, under Moodle Docs but that one generates a whole new popup browser window.
There is an issue… https://tracker.moodle.org/browse/MDL-7341 I should get trying to push that one over the line.

image

This issue makes the "Documentation for this page" link configurable in all combinations same window vs. new tab / with icon vs. without icon.

Maybe it would be worth to add the same configuration possibility for "Services and support" and "Contact site support" as well.
@lucaboesch lucaboesch added the new Something which has been reported but has not yet beeen triaged by the team label May 5, 2024
@lucaboesch lucaboesch moved this to Ready for REVIEW in Boost Union Planning Board May 6, 2024
@abias abias linked a pull request May 9, 2024 that will close this issue
Improvement: Configurable "Documentation for this page" link in footer, resolves #649. #650
Merged
@abias abias mentioned this issue May 9, 2024
Merged
@abias abias added improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) and removed new Something which has been reported but has not yet beeen triaged by the team labels May 9, 2024
@abias abias moved this from Ready for REVIEW to In Progress REVIEW in Boost Union Planning Board May 9, 2024
abias pushed a commit to lucaboesch/moodle-theme_boost_union that referenced this issue May 15, 2024
@lucaboesch @abias
Improvement: Add the option to suppress the icons in front of the foo…
adcdd2c 
…ter links, resolves moodle-an-hochschulen#649.
abias pushed a commit that referenced this issue May 16, 2024
@lucaboesch
Improvement: Configurable "Documentation for this page" link in footer,
d2de6b0 
resolves #649. (#650)
@github-project-automation github-project-automation bot moved this from In Progress REVIEW to Ready for Backport in Boost Union Planning Board May 16, 2024
abias pushed a commit that referenced this issue Jun 9, 2024
@lucaboesch @abias
Improvement: Configurable "Documentation for this page" link in footer,
49a16dc 
resolves #649. (#650)
abias pushed a commit that referenced this issue Jun 9, 2024
@lucaboesch @abias
Improvement: Configurable "Documentation for this page" link in footer,
75a47f8 
resolves #649. (#650)
abias pushed a commit that referenced this issue Jun 9, 2024
@lucaboesch @abias
Improvement: Configurable "Documentation for this page" link in footer,
8e84bbe 
resolves #649. (#650)
@abias abias moved this from Ready for Backport to Ready for Release Test in Boost Union Planning Board Jun 9, 2024
@abias abias moved this from Ready for Release Test to Ready for Release in Boost Union Planning Board Jun 11, 2024
@abias abias moved this from Ready for Release to CLOSED in Boost Union Planning Board Jun 12, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@lucaboesch
Improvement: Configurable "Documentation for this page" link in footer,
8dc04d7 
resolves moodle-an-hochschulen#649. (moodle-an-hochschulen#650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaboesch lucaboesch

Labels
improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
2 participants
@lucaboesch @abias