Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smartmenu just for logged in user #571

Closed
create-martin opened this issue Feb 23, 2024 · 3 comments
Closed

Smartmenu just for logged in user #571

create-martin opened this issue Feb 23, 2024 · 3 comments
Assignees
@stefanscholz
Labels
bug Something which isn't working

Comments

@create-martin
Copy link

Describe the bug
A clear and concise description of what the bug is.

Basically, I wanted to create a smartmenu that is visible for all logged in users (read: NOT on loginpage).

That seemed like an easy task, I restricted visibilty by role and set "Authenticated user":

image

However, that hides the smartmenu completely? For logged in users, admin etc.

Am I missing smt obvious?

I have smartmenus restricted by other roles (teacher, custom roles) and they behave exactly as expected.

To Reproduce
Steps to reproduce the behavior:
Just create a smartmenu, set role-restriction to "authenticated user" - and it's gone

Expected behavior
Should be visibly AFTER login (for everyone), but hidden on login-page
@create-martin create-martin added the new Something which has been reported but has not yet beeen triaged by the team label Feb 23, 2024
@create-martin
Copy link
Author

Any update on that issue by any chance?

@stefanscholz stefanscholz self-assigned this Apr 10, 2024
@stefanscholz stefanscholz added the bug Something which isn't working label Apr 10, 2024
@HsH-Wolf HsH-Wolf removed the new Something which has been reported but has not yet beeen triaged by the team label Apr 11, 2024
@HsH-Wolf HsH-Wolf moved this to Ready for DEV in Boost Union Planning Board Apr 11, 2024
@abias abias moved this from Ready for DEV to In Progress DEV in Boost Union Planning Board Apr 20, 2024
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Apr 25, 2024
@prasanna-lmsace
Improvement: Enhance smart menu restrictions for authenticated user a…
ae0dbea 
…nd guest roles, resolves moodle-an-hochschulen#571
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Apr 25, 2024
@prasanna-lmsace
Improvement: Enhance smart menu restrictions for authenticated and gu…
e68c840 
…est roles, resolves moodle-an-hochschulen#571
@abias abias moved this from In Progress DEV to In Progress REVIEW in Boost Union Planning Board May 11, 2024
abias pushed a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue May 11, 2024
@prasanna-lmsace @abias
Improvement: Enhance smart menu restrictions for authenticated and gu…
f541779 
…est roles, resolves moodle-an-hochschulen#571
abias pushed a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue May 11, 2024
@prasanna-lmsace @abias
Improvement: Enhance smart menu restrictions for authenticated and gu…
83fd30f 
…est roles, resolves moodle-an-hochschulen#571
@abias abias closed this as completed in 909bbab May 11, 2024
@github-project-automation github-project-automation bot moved this from In Progress REVIEW to Ready for Backport in Boost Union Planning Board May 11, 2024
@abias
Copy link
Member

abias commented May 11, 2024

@create-martin - sorry for the late reply. I hope that the fix which was just integrated into master will solve your problem.

abias pushed a commit that referenced this issue May 13, 2024
@prasanna-lmsace @abias
Improvement: Enhance smart menu restrictions for authenticated and gu…
546f6e3 
…est roles, resolves #571 (#640)
abias pushed a commit that referenced this issue May 13, 2024
@prasanna-lmsace @abias
Improvement: Enhance smart menu restrictions for authenticated and gu…
078bb39 
…est roles, resolves #571 (#640)
abias pushed a commit that referenced this issue May 13, 2024
@prasanna-lmsace @abias
Improvement: Enhance smart menu restrictions for authenticated and gu…
50c3e49 
…est roles, resolves #571 (#640)
@abias abias moved this from Ready for Backport to Ready for Release Test in Boost Union Planning Board May 13, 2024
@kaaermes kaaermes moved this from Ready for Release Test to In Progress Release Test in Boost Union Planning Board May 13, 2024
@kaaermes
Copy link
Collaborator

Moodle 4.1.10 > OK
Moodle 4.2.7 > OK

@kaaermes kaaermes moved this from In Progress Release Test to Ready for Release in Boost Union Planning Board May 13, 2024
@abias abias moved this from Ready for Release to CLOSED in Boost Union Planning Board May 15, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@prasanna-lmsace
Improvement: Enhance smart menu restrictions for authenticated and gu…
52acf47 
…est roles, resolves moodle-an-hochschulen#571 (moodle-an-hochschulen#640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanscholz stefanscholz

Labels
bug Something which isn't working
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

No branches or pull requests
5 participants
@create-martin @abias @stefanscholz @HsH-Wolf @kaaermes