Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Add admin setting for logo max-width in the navbar #544

Open
abias opened this issue Jan 18, 2024 · 2 comments · May be fixed by #659
Open

Improvement: Add admin setting for logo max-width in the navbar #544

abias opened this issue Jan 18, 2024 · 2 comments · May be fixed by #659
Assignees
@DocDanouBot
Labels
good first issue Something which can be addressed by newcomers in reasonable time improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)

Comments

@abias
Copy link
Member

abias commented Jan 18, 2024

Up to now, the size of the logo in the navbar is controlled by the height of the uploaded logo image. The width is scaled proportionally.

However, when using a logo with a really wide aspect-ratio, the logo in the navbar can become too big:

grafik

Adding a max-width setting for the navbar logo would help with this visual glitch:

grafik
@abias abias added good first issue Something which can be addressed by newcomers in reasonable time improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) labels Jan 18, 2024
@DocDanouBot
Copy link

Hello @abias and Colleagues,
I was assigned to this ticket, but i have not enough rights to also grab me this issue. could you please set me to it and push it further down the line within the kanban board? thanks

@abias abias moved this to In Progress DEV in Boost Union Planning Board May 14, 2024
@abias
Copy link
Member Author

abias commented May 14, 2024

@DocDanouBot - Thank you for pinging me. I have assigned you to this issue.

DocDanouBot pushed a commit to DocDanouBot/moodle-theme_boost_union that referenced this issue May 14, 2024
@DocDanou
finalizing the feature moodle-an-hochschulen#544
8d95dc5
DocDanouBot pushed a commit to DocDanouBot/moodle-theme_boost_union that referenced this issue May 14, 2024
@DocDanou
Building feature for maxwidth of logo if too broad in theme settings.…
c317b65 
… Issue moodle-an-hochschulen#544
DocDanouBot pushed a commit to DocDanouBot/moodle-theme_boost_union that referenced this issue May 17, 2024
@DocDanou
Finishing the task to build a theme extension in moodle-an-hochschule…
37be702 
…n#544
@abias abias moved this from In Progress DEV to In Progress REVIEW in Boost Union Planning Board May 18, 2024
@abias abias linked a pull request May 18, 2024 that will close this issue
Extending navbar logo settings with maxwidth - resolves #544 #659
Open
DocDanouBot pushed a commit to DocDanouBot/moodle-theme_boost_union that referenced this issue Aug 5, 2024
@DocDanou
Adding new feature for company logo in the navbar header img.maxwidth…
785c15f 
… through settings.php moodle-an-hochschulen#544 #MT-4714
abias pushed a commit to DocDanouBot/moodle-theme_boost_union that referenced this issue Oct 26, 2024
@DocDanou @abias
Building feature for maxwidth of logo if too broad in theme settings.…
d57653d 
… Issue moodle-an-hochschulen#544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DocDanouBot DocDanouBot

Labels
good first issue Something which can be addressed by newcomers in reasonable time improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)
Projects
Boost Union Planning Board
Status: In Progress REVIEW
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extending navbar logo settings with maxwidth - resolves #544 DocDanouBot/moodle-theme_boost_union
2 participants
@abias @DocDanouBot