Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure smart menu "locations" is filled with value #404

Closed
wiebkemueller-hsh opened this issue Sep 27, 2023 · 2 comments · Fixed by #636
Closed

Make sure smart menu "locations" is filled with value #404

wiebkemueller-hsh opened this issue Sep 27, 2023 · 2 comments · Fixed by #636
Assignees
@stefanscholz
Labels
good first issue Something which can be addressed by newcomers in reasonable time improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)

Comments

@wiebkemueller-hsh
Copy link
Collaborator

wiebkemueller-hsh commented Sep 27, 2023 •
edited
Loading

This is a follow-up issue to #300

As a user (admin) I would like to be notifyed by the system/form if a mandatory item is missing in order to show the smart menu I created.
Since it is necessary to specify a location in order to show the smart menu in the frontend, the configuration of smart menu locations field should be a mandatory field or be filled with a default start value on creation of a new smart menu.

Notes:

  • Users might be confused when all mandatory fields have been filled and the menu is still not shown.
  • In case a smart menu is used as a mere field for storing data for other (future) purposes, there should be an extra item in the options list, specifying the purpose (e.g. "no location, only data storage").
  • The hiding of a smart menu in preparation can be done via actions (hide).
@wiebkemueller-hsh wiebkemueller-hsh added the bug Something which isn't working label Sep 27, 2023
@HsH-Wolf HsH-Wolf moved this to To do REQ in Boost Union Planning Board Oct 24, 2023
@wiebkemueller-hsh wiebkemueller-hsh added the discussion needed Something which needs to be discussed before writing the first line of code label Nov 13, 2023
@wiebkemueller-hsh wiebkemueller-hsh moved this from To do REQ to Ready for DEV in Boost Union Planning Board Jan 18, 2024
@wiebkemueller-hsh wiebkemueller-hsh added good first issue Something which can be addressed by newcomers in reasonable time and removed discussion needed Something which needs to be discussed before writing the first line of code labels Jan 18, 2024
@wiebkemueller-hsh
Copy link
Collaborator Author

This is ready for dev and time has to be found to realize it. Could be a good first issue for new developers!

@abias abias added improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) and removed bug Something which isn't working labels Apr 10, 2024
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Apr 20, 2024
@prasanna-lmsace
Improve: Make sure smart menu "locations" is filled with value, resolves
e244d50 
 moodle-an-hochschulen#404
@abias abias moved this from Ready for DEV to In Progress DEV in Boost Union Planning Board Apr 20, 2024
@abias abias linked a pull request May 11, 2024 that will close this issue
Improvement: Make sure smart menu "locations" is filled with value, resolves #404 #636
Merged
abias pushed a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue May 11, 2024
@prasanna-lmsace @abias
Improve: Make sure smart menu "locations" is filled with value, resolves
dd2fa2f 
 moodle-an-hochschulen#404
@abias abias moved this from In Progress DEV to In Progress REVIEW in Boost Union Planning Board May 11, 2024
abias pushed a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue May 11, 2024
@prasanna-lmsace @abias
Improve: Make sure smart menu "locations" is filled with value, resolves
58446af 
 moodle-an-hochschulen#404
abias pushed a commit that referenced this issue May 11, 2024
@prasanna-lmsace
Improvement: Make sure smart menu "locations" is filled with value, r…
af0be32 
…esolves #404 (#636)
@github-project-automation github-project-automation bot moved this from In Progress REVIEW to Ready for Backport in Boost Union Planning Board May 11, 2024
abias pushed a commit that referenced this issue May 13, 2024
@prasanna-lmsace @abias
Improvement: Make sure smart menu "locations" is filled with value, r…
d976ce1 
…esolves #404 (#636)
abias pushed a commit that referenced this issue May 13, 2024
@prasanna-lmsace @abias
Improvement: Make sure smart menu "locations" is filled with value, r…
5cbd1cc 
…esolves #404 (#636)
abias pushed a commit that referenced this issue May 13, 2024
@prasanna-lmsace @abias
Improvement: Make sure smart menu "locations" is filled with value, r…
120574b 
…esolves #404 (#636)
@abias abias moved this from Ready for Backport to Ready for Release Test in Boost Union Planning Board May 13, 2024
@kaaermes kaaermes moved this from Ready for Release Test to In Progress Release Test in Boost Union Planning Board May 13, 2024
@kaaermes
Copy link
Collaborator

field "Menu location(s)" is mandatory

Moodle 4.1.10 > OK
Moodle 4.2.7 > OK

Bildschirmfoto 2024-05-13 um 15 29 37

@kaaermes kaaermes moved this from In Progress Release Test to Ready for Release in Boost Union Planning Board May 13, 2024
@abias abias moved this from Ready for Release to CLOSED in Boost Union Planning Board May 15, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@prasanna-lmsace
Improvement: Make sure smart menu "locations" is filled with value, r…
9207609 
…esolves moodle-an-hochschulen#404 (moodle-an-hochschulen#636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanscholz stefanscholz

Labels
good first issue Something which can be addressed by newcomers in reasonable time improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
4 participants
@abias @stefanscholz @wiebkemueller-hsh @kaaermes