Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Complete the test set for the smart menus feature #375

Closed
abias opened this issue Aug 26, 2023 · 1 comment
Closed

Test: Complete the test set for the smart menus feature #375

abias opened this issue Aug 26, 2023 · 1 comment
Assignees
@stefanscholz
Labels
test Something which targets automated tests (Behat, PHPUnit)

Comments

@abias
Copy link
Member

abias commented Aug 26, 2023

This is a follow-up issue to #300

The test set for the smart menus feature is incomplete, unfortunately.

The following tests for smart menu options should be added:

  • Advanced settings -> More menu behavior
  • Card appearance -> Overflow behavior

The following tests for smart menu items should be added:

  • General -> Type -> Heading (There is no dedicated tests for testing that headings work)
  • General -> Type -> Static (There is no dedicated tests for testing that static menu items work
  • Appearance -> Mode -> Submenu (There is no test which tests the third menu level)
  • Appearance -> Icon
  • Appearance -> Display options
  • Appearance -> Tooltip
  • Appearance -> Order
  • Appearance -> Responsive
  • Card appearance -> Image
  • Card appearance -> Text position
  • Card appearance -> Text color
  • Card appearance -> Background color

If a particular feature cannot be tested with Behat, it should be mentioned anyway in a Behat scenario with a note like
https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/tests/behat/theme_boost_union_looksettings_sitebranding.feature#L141-L142 for the sake of completeness
@abias abias added feature Something which is a new feature or big improvement test Something which targets automated tests (Behat, PHPUnit) and removed feature Something which is a new feature or big improvement labels Aug 26, 2023
@abias abias changed the title Improvement: Complete the test set for the smart menus feature Test: Complete the test set for the smart menus feature Aug 27, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Sep 22, 2023
@prasanna-lmsace
Missing test cases included for the menu and menu items
e9acf75 
- Fix moodle-an-hochschulen#375, UN-240
@abias abias moved this to In Progress DEV in Boost Union Planning Board Nov 5, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 15, 2023
@prasanna-lmsace
Test: Complete the test set for the smart menus feature, solves moodl…
dc2c716 
…e-an-hochschulen#375
@abias abias moved this from In Progress DEV to Ready for REVIEW in Boost Union Planning Board Dec 16, 2023
lucaboesch pushed a commit that referenced this issue Dec 20, 2023
@prasanna-lmsace @lucaboesch
Test: Complete the test set for the smart menus feature, solves #375
ccd45fa
@lucaboesch lucaboesch mentioned this issue Dec 20, 2023
Merged
@lucaboesch
Copy link
Collaborator

Fixed by #501.
Closing.

@github-project-automation github-project-automation bot moved this from Ready for REVIEW to CLOSED in Boost Union Planning Board Dec 20, 2023
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Complete the test set for the smart menus feature, solves #375
ab392fb
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Complete the test set for the smart menus feature, solves #375
db810b9
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Complete the test set for the smart menus feature, solves #375
241d602
abias pushed a commit that referenced this issue Jan 14, 2024
@prasanna-lmsace @abias
Test: Complete the test set for the smart menus feature, solves #375
c2067fe
abias pushed a commit that referenced this issue Jan 14, 2024
@prasanna-lmsace @abias
Test: Complete the test set for the smart menus feature, solves #375
4883096
@abias abias mentioned this issue Apr 7, 2024
Closed
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@prasanna-lmsace @lucaboesch
Test: Complete the test set for the smart menus feature, solves moodl…
32972d5 
…e-an-hochschulen#375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanscholz stefanscholz

Labels
test Something which targets automated tests (Behat, PHPUnit)
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lucaboesch @abias @stefanscholz