Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Complete tests for smart menu visibility restriction by role #374

Closed
abias opened this issue Aug 26, 2023 · 1 comment
Closed

Test: Complete tests for smart menu visibility restriction by role #374

abias opened this issue Aug 26, 2023 · 1 comment
Assignees
@stefanscholz
Labels
test Something which targets automated tests (Behat, PHPUnit)

Comments

@abias
Copy link
Member

abias commented Aug 26, 2023

This is a follow-up issue to #300.

In

moodle-theme_boost_union/tests/behat/theme_boost_union_menu_rules.feature

Line 48 in f5d5932

Scenario: Smartmenu: Access Rules - Based on the user roles
and

moodle-theme_boost_union/tests/behat/theme_boost_union_menuitem_rules.feature

Line 54 in f5d5932

Scenario: Smartmenuitem: Access Rules - Based on the user roles
, there are test scenarios for restricting the visibility of smart menus and smart menu items per role. But the "Restrict visibility by role" feature has a Context option as well which can be set to "System" or "Any" which is not covered by the Behat test. This should be added.
@abias abias added feature Something which is a new feature or big improvement test Something which targets automated tests (Behat, PHPUnit) and removed feature Something which is a new feature or big improvement labels Aug 26, 2023
@abias abias changed the title Improvement: Complete tests for smart menu visibility restriction by role Test: Complete tests for smart menu visibility restriction by role Aug 27, 2023
@abias abias moved this to In Progress DEV in Boost Union Planning Board Nov 5, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 14, 2023
@prasanna-lmsace
Test: Complete tests for smart menu visibility restriction by role, s…
3a24ee6 
…olves moodle-an-hochschulen#374
lucaboesch pushed a commit that referenced this issue Dec 20, 2023
@prasanna-lmsace @lucaboesch
Test: Complete tests for smart menu visibility restriction by role, s…
c323eaf 
…olves #374
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Complete tests for smart menu visibility restriction by role, s…
986391f 
…olves #374
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Complete tests for smart menu visibility restriction by role, s…
00c30f9 
…olves #374
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Complete tests for smart menu visibility restriction by role, s…
7d31b76 
…olves #374
@abias
Copy link
Member Author

abias commented Feb 17, 2024

This was solved some time ago by #499

@abias abias closed this as completed Feb 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress DEV to Ready for Release Test in Boost Union Planning Board Feb 17, 2024
@abias abias moved this from Ready for Release Test to CLOSED in Boost Union Planning Board Feb 17, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@prasanna-lmsace @lucaboesch
Test: Complete tests for smart menu visibility restriction by role, s…
a2c7ef3 
…olves moodle-an-hochschulen#374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanscholz stefanscholz

Labels
test Something which targets automated tests (Behat, PHPUnit)
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abias @stefanscholz