Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Align smart menu test with the smart menu item test for css classes #367

Closed
abias opened this issue Aug 22, 2023 · 1 comment
Closed

Test: Align smart menu test with the smart menu item test for css classes #367

abias opened this issue Aug 22, 2023 · 1 comment
Assignees
@stefanscholz
Labels
good first issue Something which can be addressed by newcomers in reasonable time test Something which targets automated tests (Behat, PHPUnit)

Comments

@abias
Copy link
Member

abias commented Aug 22, 2023

This is a follow-up issue to #300.

The

moodle-theme_boost_union/tests/behat/theme_boost_union_menuitemsettings_application.feature

Line 168 in f5d5932

Scenario: Smartmenuitem: Application - Include the custom css class for menu items
test tests the css classes for menu items in all smart menu areas (Main, User, Bottom, Menubar), but the corresponding test

moodle-theme_boost_union/tests/behat/theme_boost_union_menusettings_application.feature

Line 151 in f5d5932

Scenario: Smartmenu: Application - Include the custom css class for menu
for menus does only test the main navigation.

It would be worthwhile to align the menu test with the menu item test.
@abias abias added feature Something which is a new feature or big improvement test Something which targets automated tests (Behat, PHPUnit) good first issue Something which can be addressed by newcomers in reasonable time and removed feature Something which is a new feature or big improvement labels Aug 22, 2023
@abias abias changed the title Improvement: Align smart menu test with the smart menu item test for css classes Test: Align smart menu test with the smart menu item test for css classes Aug 27, 2023
@abias abias moved this to In Progress DEV in Boost Union Planning Board Nov 5, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 15, 2023
@prasanna-lmsace
Test: Align smart menu test with the smart menu item test for css cla…
e92f23a 
…sses, solves moodle-an-hochschulen#367
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 15, 2023
@prasanna-lmsace
Test: Align smart menu test with the smart menu item test for css cla…
fba1b5f 
…sses, solves moodle-an-hochschulen#367
lucaboesch pushed a commit that referenced this issue Dec 20, 2023
@prasanna-lmsace @lucaboesch
Test: Align smart menu test with the smart menu item test for css cla…
e31927d 
…sses, solves #367
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Align smart menu test with the smart menu item test for css cla…
c2a191a 
…sses, solves #367
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Align smart menu test with the smart menu item test for css cla…
96ca7a5 
…sses, solves #367
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Align smart menu test with the smart menu item test for css cla…
68a8ad4 
…sses, solves #367
abias pushed a commit that referenced this issue Jan 14, 2024
@prasanna-lmsace @abias
Test: Align smart menu test with the smart menu item test for css cla…
9c493e9 
…sses, solves #367
abias pushed a commit that referenced this issue Jan 14, 2024
@prasanna-lmsace @abias
Test: Align smart menu test with the smart menu item test for css cla…
ef9a7ec 
…sses, solves #367
@abias
Copy link
Member Author

abias commented Feb 17, 2024

This was solved some time ago by #501

@abias abias closed this as completed Feb 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress DEV to Ready for Release Test in Boost Union Planning Board Feb 17, 2024
@abias abias moved this from Ready for Release Test to CLOSED in Boost Union Planning Board Feb 17, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@prasanna-lmsace @lucaboesch
Test: Align smart menu test with the smart menu item test for css cla…
97298cf 
…sses, solves moodle-an-hochschulen#367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanscholz stefanscholz

Labels
good first issue Something which can be addressed by newcomers in reasonable time test Something which targets automated tests (Behat, PHPUnit)
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abias @stefanscholz