Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Add tests for smart menu visibility restriction by date #364

Closed
abias opened this issue Aug 21, 2023 · 1 comment
Closed

Test: Add tests for smart menu visibility restriction by date #364

abias opened this issue Aug 21, 2023 · 1 comment
Assignees
@stefanscholz
Labels
good first issue Something which can be addressed by newcomers in reasonable time test Something which targets automated tests (Behat, PHPUnit)

Comments

@abias
Copy link
Member

abias commented Aug 21, 2023 •
edited
Loading

This is a follow-up issue to #300.

In https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/f5d593275c6ec4e8d2e446e3f82a51823e2f6e87/tests/behat/theme_boost_union_menu_rules.feature and https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/f5d593275c6ec4e8d2e446e3f82a51823e2f6e87/tests/behat/theme_boost_union_menuitem_rules.feature, there are test scenarios for restricting the visibility of smart menus and smart menu items per cohort, per role and per language. But there aren't any tests for restricting the visibility of smart menus and smart menu items per date which is a usable feature as well.
@abias abias added feature Something which is a new feature or big improvement test Something which targets automated tests (Behat, PHPUnit) good first issue Something which can be addressed by newcomers in reasonable time and removed feature Something which is a new feature or big improvement labels Aug 21, 2023
@abias abias changed the title Improvement: Add tests for smart menu visibility restriction by date Test: Add tests for smart menu visibility restriction by date Aug 27, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Sep 22, 2023
@prasanna-lmsace
Include test for smart menu visibility restriction by date
c7fd388 
- Fix moodle-an-hochschulen#364, UN-239
@abias abias moved this to In Progress DEV in Boost Union Planning Board Nov 5, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 12, 2023
@prasanna-lmsace
Test: Smart menu visibility restriction by date, solves moodle-an-hoc…
9da3874 
…hschulen#364
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 13, 2023
@prasanna-lmsace
Test: Tests for smart menu visibility restriction by date, solves moo…
e30e159 
…dle-an-hochschulen#364
@abias abias moved this from In Progress DEV to Ready for REVIEW in Boost Union Planning Board Dec 16, 2023
lucaboesch pushed a commit that referenced this issue Dec 20, 2023
@prasanna-lmsace @lucaboesch
Test: Tests for smart menu visibility restriction by date, solves #364
bc9e42a
@lucaboesch
Copy link
Collaborator

This can be closed.

@github-project-automation github-project-automation bot moved this from Ready for REVIEW to CLOSED in Boost Union Planning Board Dec 20, 2023
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Tests for smart menu visibility restriction by date, solves #364
49596a5
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Tests for smart menu visibility restriction by date, solves #364
239a903
abias pushed a commit that referenced this issue Jan 13, 2024
@prasanna-lmsace @abias
Test: Tests for smart menu visibility restriction by date, solves #364
528e3c5
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@prasanna-lmsace @lucaboesch
Test: Tests for smart menu visibility restriction by date, solves moo…
41f3fa7 
…dle-an-hochschulen#364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanscholz stefanscholz

Labels
good first issue Something which can be addressed by newcomers in reasonable time test Something which targets automated tests (Behat, PHPUnit)
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lucaboesch @abias @stefanscholz