-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Replace 'I should see "..." style "..." value "..."' Behat step in smart menus #363
Labels
test
Something which targets automated tests (Behat, PHPUnit)
Comments
abias
added
feature
Something which is a new feature or big improvement
test
Something which targets automated tests (Behat, PHPUnit)
and removed
feature
Something which is a new feature or big improvement
labels
Aug 20, 2023
abias
changed the title
Improvement: Replace 'I should see "..." style "..." value "..."' Behat step in smart menus
Test: Replace 'I should see "..." style "..." value "..."' Behat step in smart menus
Aug 27, 2023
prasanna-lmsace
added a commit
to bdecentgmbh/moodle-theme_boost_union
that referenced
this issue
Dec 19, 2023
… in smart menus, solves moodle-an-hochschulen#363
This was solved some time ago by #501 |
github-project-automation
bot
moved this to Ready for Release Test
in Boost Union Planning Board
Feb 17, 2024
detomon
pushed a commit
to detomon/moodle-theme_boost_union
that referenced
this issue
Aug 26, 2024
… in smart menus, solves moodle-an-hochschulen#363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow-up issue to #300
The smart menu patch shipped with a new Behat test step
I should see "..." style "..." value "..."
This step is just used once in a scenario on https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/f5d593275c6ec4e8d2e446e3f82a51823e2f6e87/tests/behat/theme_boost_union_menusettings_application.feature#L213C70-L213C73
According to my understanding, this step does more or less the same
moodle-theme_boost_union/tests/behat/behat_theme_boost_union_behat_smartmenus.php
Lines 97 to 121 in f5d5932
DOM element ... should have computed style ... ...
step which exists in Boost Union already does.It would be worthwhile to get rid of this duplicated step and just use one step for the same purpose.
The text was updated successfully, but these errors were encountered: