Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: Fix smart menu mustache linter warnings #362

Closed
abias opened this issue Aug 19, 2023 · 1 comment
Closed

Release: Fix smart menu mustache linter warnings #362

abias opened this issue Aug 19, 2023 · 1 comment
Assignees
@stefanscholz
Labels
good first issue Something which can be addressed by newcomers in reasonable time release tasks Something which should be done before officially publishing the next release

Comments

@abias
Copy link
Member

abias commented Aug 19, 2023 •
edited
Loading

This is a follow-up issue to #300

If you look at a recent GHA run on https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/actions, you will notice that there are several mustache linter warnings which originate from the smart menus contribution.

These warnings are:

/home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/templates/smartmenus-cardmenu-children.mustache - WARNING: HTML Validation error, line 2: Element “li” not allowed as child of element “body” in this context. (Suppressing further errors from this subtree.) (body>    <li data-key="" class="nav-item" role="none" data-forceintomoremenu="false">     )
/home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/templates/smartmenus-cardmenu-children.mustache - WARNING: HTML Validation error, line 9: An element with “role=menuitem” must be contained in, or owned by, an element with “role=menubar” or “role=menu”. (          <a role="menuitem" class="nav-link  "                    href="https://moodle.org"                                        tabindex="-1"                                                        >     )

/home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/templates/fontawesome-iconpicker-popover.mustache - WARNING: HTML Validation error, line 4: Attribute “aria-value” not allowed on element “li” at this point. (          <li aria-value="core:book" aria-label="fa-book"><i cla)
/home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/templates/fontawesome-iconpicker-popover.mustache - INFO: HTML Validation info, line 4: Possible misuse of “aria-label”. (If you disagree with this warning, file an issue report or send e-mail to [email protected].) (          <li aria-value="core:book" aria-label="fa-book"><i cla)
/home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/templates/fontawesome-iconpicker-popover.mustache - WARNING: HTML Validation error, line 5: Attribute “aria-value” not allowed on element “li” at this point. (          <li aria-value="core:docs" aria-label="fa-info-circle"><i cla)
/home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/templates/fontawesome-iconpicker-popover.mustache - INFO: HTML Validation info, line 5: Possible misuse of “aria-label”. (If you disagree with this warning, file an issue report or send e-mail to [email protected].) (          <li aria-value="core:docs" aria-label="fa-info-circle"><i cla)

The GHA job does not fail because of this line:
https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/.github/workflows/moodle-plugin-ci.yml#L97

However, these warnings should be fixed anyway.
@abias abias added good first issue Something which can be addressed by newcomers in reasonable time release tasks Something which should be done before officially publishing the next release labels Aug 22, 2023
@abias abias changed the title Bug: Fix smart menu mustache linter warnings Release: Fix smart menu mustache linter warnings Sep 22, 2023
@HsH-Wolf HsH-Wolf added the upgrade Something which needs to be done to upgrade the plugin to a new Moodle major release label Nov 1, 2023
@abias abias removed the upgrade Something which needs to be done to upgrade the plugin to a new Moodle major release label Nov 2, 2023
@abias abias moved this to In Progress DEV in Boost Union Planning Board Nov 5, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 19, 2023
@prasanna-lmsace
Fix smart menu mustache linter warnings, solves moodle-an-hochschulen…
e3c9cb6 
…#362
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 20, 2023
@prasanna-lmsace
Fix smart menu mustache linter warnings, solves moodle-an-hochschulen…
cf8837b 
…#362
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 20, 2023
@prasanna-lmsace
Fix smart menu mustache linter warnings, solves moodle-an-hochschulen…
42a13b0 
…#362
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 21, 2023
@prasanna-lmsace
Fix smart menu mustache linter warnings, solves moodle-an-hochschulen…
b069405 
…#362
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Dec 26, 2023
@prasanna-lmsace
Fix smart menu mustache linter warnings, solves moodle-an-hochschulen…
6af2053 
…#362
@whuml whuml linked a pull request Jan 9, 2024 that will close this issue
Fix smart menu mustache linter warnings, solves #362 #508
Closed
@abias abias moved this from In Progress DEV to In Progress REVIEW in Boost Union Planning Board Feb 17, 2024
@abias abias mentioned this issue Feb 19, 2024
Closed
abias added a commit that referenced this issue Feb 19, 2024
@abias
Fix smart menu mustache linter warnings, relates to #362
443dfa9
abias added a commit that referenced this issue Feb 19, 2024
@abias
Fix smart menu mustache linter warnings, relates to #362
d1e9c3d
abias pushed a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Feb 19, 2024
@prasanna-lmsace @abias
Fix smart menu mustache linter warnings, solves moodle-an-hochschulen…
1f94941 
…#362
@abias abias mentioned this issue Feb 19, 2024
Closed
abias added a commit that referenced this issue Feb 19, 2024
@abias
Fix smart menu mustache linter warnings, relates to #362
588a8f3
abias added a commit that referenced this issue Feb 19, 2024
@abias
Fix smart menu mustache linter warnings, relates to #362
c1d1195
abias added a commit that referenced this issue Feb 19, 2024
@abias
Fix smart menu mustache linter warnings, relates to #362
34b08c4
@abias
Copy link
Member Author

abias commented Feb 19, 2024

This was discussed and solved in #508

@abias abias closed this as completed Feb 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress REVIEW to Ready for Release Test in Boost Union Planning Board Feb 19, 2024
@abias abias moved this from Ready for Release Test to CLOSED in Boost Union Planning Board Feb 19, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@abias
Fix smart menu mustache linter warnings, relates to moodle-an-hochsch…
4154a87 
…ulen#362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanscholz stefanscholz

Labels
good first issue Something which can be addressed by newcomers in reasonable time release tasks Something which should be done before officially publishing the next release
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix smart menu mustache linter warnings, solves #362 bdecentgmbh/moodle-theme_boost_union
3 participants
@abias @stefanscholz @HsH-Wolf