Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Smart menu language restriction does not respect switching language with the language switcher #358

Closed
abias opened this issue Aug 17, 2023 · 0 comments
Assignees
Labels
bug Something which isn't working

Comments

@abias
Copy link
Member

abias commented Aug 17, 2023

This is a follow-up issue to #300 and is related to #376

Steps to reproduce:

  • Login as admin
  • Go to Site administration -> Language -> Language packs and install the german language pack
  • Go to Site administration -> Language -> Language settings, set the language of the site to english and enable the langmenu
  • Go to Site administration -> Appearance -> Boost Union -> Smart menus
  • Create a new smart menu
  • Set the location to main navigation
  • Set an arbitrary menu title
  • Set "Restrict visibility by language" to "German"
  • Login as teacher
  • Go to your user profile settings and set your preferred language to german
  • Verify that you see the smart menu in the main navigation
  • Go to your user profile settings again and set your preferred language to english
  • Verify that you do not see the smart menu in the main navigation
  • Go to the language menu in the user menu and switch the language to german

Expected result:

  • You see the smart menu in the main navigation again

Actual result:

  • You do not see the smart menu in the main navigation again

Analysis:

  • The "Restrict visibility by language" seems not to really respect the language which is currently used on the current Moodle page.
@abias abias added the bug Something which isn't working label Aug 17, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Sep 13, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Sep 15, 2023
@abias abias closed this as completed in c668df2 Sep 22, 2023
@abias abias reopened this Sep 25, 2023
@abias abias closed this as completed in 6ec2175 Sep 27, 2023
@abias abias self-assigned this Sep 27, 2023
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something which isn't working
Projects
Status: CLOSED
Development

No branches or pull requests

1 participant