Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Smartmenus.js should only be added to the page if smart menus are really used #357

Closed
abias opened this issue Aug 17, 2023 · 0 comments
Closed

Improvement: Smartmenus.js should only be added to the page if smart menus are really used #357

abias opened this issue Aug 17, 2023 · 0 comments
Assignees
@abias
Labels
feature Something which is a new feature or big improvement

Comments

@abias
Copy link
Member

abias commented Aug 17, 2023 •
edited
Loading

This is a follow-up issue to #300

Similar to this change here:
bbbdb49,

I would appreciate of smartmenus.js would only be assed to the page if smart menus are really used. If the admin did not configure any smart menu or - even better - if not a single smart menu item is shown on the given page, smartmenus.js should not be added to drawers.mustache and columns2.mustache.
@abias abias added the feature Something which is a new feature or big improvement label Aug 17, 2023
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Sep 6, 2023
@prasanna-lmsace
Smart menu JS included to the page based on menus count.
5579ac1 
- Fix moodle-an-hochschulen#357, UN-231
prasanna-lmsace added a commit to bdecentgmbh/moodle-theme_boost_union that referenced this issue Sep 16, 2023
@prasanna-lmsace
Smart menu JS included to the page based on menus existence.
5112546 
- Fix moodle-an-hochschulen#357, UN-231
@abias abias closed this as completed in abbc3ab Sep 22, 2023
@abias abias mentioned this issue Sep 22, 2023
Closed
@abias abias reopened this Sep 25, 2023
abias pushed a commit that referenced this issue Sep 25, 2023
@prasanna-lmsace @abias
Smart menu JS included to the page based on menus existence.
a3fac99 
- Fix #357, UN-231
abias pushed a commit that referenced this issue Sep 26, 2023
@prasanna-lmsace @abias
Smart menu JS included to the page based on menus existence.
8d2a3f4 
- Fix #357, UN-231
@abias abias closed this as completed in eede937 Sep 27, 2023
@abias abias self-assigned this Sep 27, 2023
abias pushed a commit that referenced this issue Oct 7, 2023
@prasanna-lmsace @abias
Smart menu JS included to the page based on menus existence.
1f4c22d 
- Fix #357, UN-231
abias pushed a commit that referenced this issue Oct 7, 2023
@prasanna-lmsace @abias
Smart menu JS included to the page based on menus existence.
ab04d1e 
- Fix #357, UN-231
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@prasanna-lmsace @abias
Smart menu JS included to the page based on menus existence.
3455946 
- Fix moodle-an-hochschulen#357, UN-231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abias abias

Labels
feature Something which is a new feature or big improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abias