Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Changing module purpose to "other" makes icon background white instead of grey #333

Closed
abias opened this issue Jul 7, 2023 · 1 comment
Closed

Bug: Changing module purpose to "other" makes icon background white instead of grey #333

abias opened this issue Jul 7, 2023 · 1 comment
Assignees
@abias
Labels
bug Something which isn't working

Comments

@abias
Copy link
Member

abias commented Jul 7, 2023

The default background color of an "other" activity is grey.
But if you change the purpose of a "non-other" activity to "other", the background is just white.

In this screenshot, the BBB activity is "other" by default, the forum activity was changed to "other":

grafik

This bug is caused by the fact that Boost Union tries to set the background color with a --activityother variable. However, this variable does not exist. Instead, the background color must not be set at all in this case so that the default = grey background color is used.
@abias abias added the bug Something which isn't working label Jul 7, 2023
@abias abias self-assigned this Jul 7, 2023
@abias abias changed the title Bug: Changing module purpose to "other" makes icon makes icon background white instead of grey Bug: Changing module purpose to "other" makes icon background white instead of grey Jul 7, 2023
abias added a commit that referenced this issue Jul 7, 2023
@abias
Bugfix: Changing module purpose to other made icon background white i…
4a5cab8 
…nstead of grey, solves #333.
abias added a commit that referenced this issue Jul 8, 2023
@abias
Bugfix: Changing module purpose to other made icon background white i…
b674193 
…nstead of grey, solves #333. (#334)
@abias
Copy link
Member Author

abias commented Jul 8, 2023

This was solved by #334

@abias abias closed this as completed Jul 8, 2023
abias added a commit that referenced this issue Jul 24, 2023
@abias
Bugfix: Changing module purpose to other made icon background white i…
a927ccc 
…nstead of grey, solves #333. (#334)
abias added a commit that referenced this issue Jul 24, 2023
@abias
Bugfix: Changing module purpose to other made icon background white i…
e7a6749 
…nstead of grey, solves #333. (#334)
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@abias
Bugfix: Changing module purpose to other made icon background white i…
dd45bbc 
…nstead of grey, solves moodle-an-hochschulen#333. (moodle-an-hochschulen#334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abias abias

Labels
bug Something which isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abias