Improve smart menu settings forms

moodle-an-hochschulen · Aug 31, 2023 · 3e92fd0 · 3e92fd0
1 parent c37932f
commit 3e92fd0
Show file tree

Hide file tree

Showing 11 changed files with 401 additions and 303 deletions.
diff --git a/classes/form/smartmenu_form.php b/classes/form/smartmenu_form.php
@@ -205,8 +205,8 @@ public function definition() {
         $mform->addHelpButton('start_date', 'smartmenusfrom', 'theme_boost_union');
 
         $mform->addElement('date_time_selector', 'end_date',
-            get_string('smartmenusdurationuntil', 'theme_boost_union'), array('optional' => true));
-        $mform->addHelpButton('end_date', 'smartmenusdurationuntil', 'theme_boost_union');
+            get_string('smartmenusuntil', 'theme_boost_union'), array('optional' => true));
+        $mform->addHelpButton('end_date', 'smartmenusuntil', 'theme_boost_union');
 
         // Add the Submit button.
         // When two elements we need a group.

diff --git a/classes/form/smartmenu_item_form.php b/classes/form/smartmenu_item_form.php
@@ -326,8 +326,8 @@ public function definition() {
         $mform->addHelpButton('start_date', 'smartmenusfrom', 'theme_boost_union');
         // Hide the item, if the end date is reached.
         $mform->addElement('date_time_selector', 'end_date',
-            get_string('smartmenusdurationuntil', 'theme_boost_union'), array('optional' => true));
-        $mform->addHelpButton('end_date', 'smartmenusdurationuntil', 'theme_boost_union');
+            get_string('smartmenusuntil', 'theme_boost_union'), array('optional' => true));
+        $mform->addHelpButton('end_date', 'smartmenusuntil', 'theme_boost_union');
 
         $this->add_action_buttons();
     }

diff --git a/classes/smartmenu.php b/classes/smartmenu.php
@@ -898,7 +898,7 @@ public static function manage_instance($formdata) {
             // New menu added, recreate the menuslist.
             $cache->delete(self::CACHE_MENUSLIST);
             // Show the menu inserted success notification.
-            \core\notification::success(get_string('smartmenusinsertsuccess', 'theme_boost_union'));
+            \core\notification::success(get_string('smartmenusinsertmenusuccess', 'theme_boost_union'));
         }
 
         // Allow to update the DB changes to Database.

diff --git a/classes/smartmenu_item.php b/classes/smartmenu_item.php
@@ -1297,8 +1297,8 @@ public static function manage_instance($formdata) {
                 WHERE sortorder >= :sortorder AND id != :item AND menu=:menuid";
 
             $DB->execute($sql, ['sortorder' => $record->sortorder, 'item' => $itemid, 'menuid' => $record->menu]);
-            // Show the menu inserted success notification.
-            \core\notification::success(get_string('smartmenusinsertsuccess', 'theme_boost_union'));
+            // Show the menu item inserted success notification.
+            \core\notification::success(get_string('smartmenusinsertmenuitemsuccess', 'theme_boost_union'));
 
             // Delete the cached data of its menu. Menu will recreate with this item.
             $menucache->delete_menu($formdata->menu);