Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MES-795: restrict Terraform Azure provider max version #10

Merged
merged 1 commit into from
Oct 18, 2024
Merged

MES-795: restrict Terraform Azure provider max version #10

merged 1 commit into from
Oct 18, 2024

Conversation

mrostan
Copy link
Contributor

@mrostan mrostan commented Oct 18, 2024

  • We started getting an error when the latest Azure provider version (> 4.0) is used, as they made "subscriptionId" a required field when defining the Azure provider
  • This PR sets the max version to the less than 4.0 to avoid that error
  • Wrapper version increased to 1.0.2

@linear Linear
Copy link

linear bot commented Oct 18, 2024

MES-795 [Interim] Set a max provider version

@mrostan mrostan requested a review from pxc-dev October 18, 2024 14:42
@mrostan mrostan marked this pull request as ready for review October 18, 2024 14:42
@mrostan mrostan requested a review from a team as a code owner October 18, 2024 14:42
pxc-dev
pxc-dev approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@pxc-dev pxc-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should do this for the other modules too.

@mrostan mrostan merged commit d263cfe into main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxc-dev pxc-dev pxc-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrostan @pxc-dev