Removing provider definition #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er. The current provider design doesn't allow for runs via HCP Terraform and the use of an assumed role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current module design uses a module declared provider which prevents its use in a scenario where the module is being deployed by a larger project/parent module especially when that parent module leverages an AWS Assumed Role deployment for the AWS provider. Specifically in HCP Terraform when using an assume_role_arn for the parent module, it does not get passed to this module as a submodule and because this module specifies it's own provider configuration, you cannot override its provider configuration. This is a blocker for our deployment. Invocation of this module should delegate the decision on AWS credential sourcing methods (assumed role, cli profile, etc.) to the calling parent module.