-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial AWS Agent wrapper module #1
Merged
pxc-dev
merged 18 commits into
main
from
pchawla/kil-2890-add-support-for-an-aws-agent-terraform-wrapper
Dec 18, 2023
Merged
Initial AWS Agent wrapper module #1
pxc-dev
merged 18 commits into
main
from
pchawla/kil-2890-add-support-for-an-aws-agent-terraform-wrapper
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that's what we expect on Monolith
delkopiso
reviewed
Dec 18, 2023
mrostan
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
pxc-dev
deleted the
pchawla/kil-2890-add-support-for-an-aws-agent-terraform-wrapper
branch
December 18, 2023 21:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for deploying and managing a
montecarlodata/agent
via Terraform on AWS.As outlined here this wrapper module will generate resources to deploy the Dockerhub sourced Apollo agent to Lambda with a storage bucket and various roles. Also included is optional vpc and remote upgrade support as well as a developer example with standard module scaffolding and CI/CD via Circle.
It's recommended to start the review with the README, and you can find a live dev example here: