Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIL-2772 Build lambda image for ECR #39

Merged
merged 6 commits into from
Nov 29, 2023
Merged

KIL-2772 Build lambda image for ECR #39

merged 6 commits into from
Nov 29, 2023

Conversation

delkopiso
Copy link
Contributor

@delkopiso delkopiso commented Nov 29, 2023

What's new?

  • Adds a new build-and-push-lambda command that runs on the dev branch to publish the mcd-pre-release-agent to ECR, and and on the main branch to publish the mcd-agent image to ECR. Runs in parallel with the pre-existing build-and-push command so the overall build doesn't increase.
  • Updates the verify-version-in-docker-image command to run with python as the entrypoint to override the default entrypoint of lambda-based images.

Preview

Screenshot 2023-11-29 at 8 51 08 AM

Related issues and PRs

Copy link

linear bot commented Nov 29, 2023

KIL-2772 Publish agent image to AWS ECR

Why should we make this change?

Customers impacted:

Proposed change:

Update CI/CD workflow to publish to public AWS ECR

Requirements:

What are the user interactions to be tracked?

@delkopiso delkopiso force-pushed the kuzokwe/kil-2772/ecr branch 10 times, most recently from c421eeb to e400b1f Compare November 29, 2023 03:59
@delkopiso delkopiso force-pushed the kuzokwe/kil-2772/ecr branch from e400b1f to b9c3828 Compare November 29, 2023 04:02
@delkopiso delkopiso marked this pull request as ready for review November 29, 2023 13:54
@delkopiso delkopiso requested a review from a team as a code owner November 29, 2023 13:54
Copy link
Contributor

@mrostan mrostan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, left a comment about installing git as I think it's not needed

Dockerfile Outdated Show resolved Hide resolved
@delkopiso delkopiso merged commit da27d23 into main Nov 29, 2023
2 checks passed
@delkopiso delkopiso deleted the kuzokwe/kil-2772/ecr branch November 29, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants